-
Notifications
You must be signed in to change notification settings - Fork 71
Bridge dependencies on Bootstrap class/interface unclear #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
andig
added a commit
to andig/php-pm-httpkernel
that referenced
this issue
Apr 29, 2016
andig
added a commit
to andig/php-pm
that referenced
this issue
Apr 29, 2016
This was referenced Apr 29, 2016
andig
added a commit
to andig/php-pm-httpkernel
that referenced
this issue
Apr 29, 2016
andig
added a commit
to andig/php-pm-httpkernel
that referenced
this issue
Apr 29, 2016
andig
added a commit
to andig/php-pm-httpkernel
that referenced
this issue
Apr 30, 2016
@marcj ok to merge the other one as well? Will only work if I get both ;) |
andig
added a commit
to andig/php-pm-httpkernel
that referenced
this issue
Apr 30, 2016
andig
added a commit
to andig/php-pm-httpkernel
that referenced
this issue
Apr 30, 2016
marcj
added a commit
that referenced
this issue
May 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm seeing problems trying to get my application up and running again on "naked" HttpKernelAdapter:
This is what it comes down to:
BridgeInterface
apparently relies onBootstrapInterface
but doesn't declare this dependency in the constructor https://github.com/php-pm/php-pm/blob/master/Bridges/BridgeInterface.php#L17. This dependency should be explicit?HttpKernel->getStaticDirectory
relies onBootstrapInterface->getStaticDirectory
which isn't part of the interface (https://github.com/php-pm/php-pm-httpkernel/blob/master/Bridges/HttpKernel.php#L59). We could either addgetStaticDirectory
to theBootstrapInterface
but it feels kind of redundant and some applications may not need it (they could return empty- I'd prefer this approach). Alternatively add a secondStaticContentInterface
that a bridge can chose to implement or not- sounds a bit overkill?BootstrapInterface->requestClass()
which isn't part of the interface. An approach might again be forHttpKernel
to use Symfony/HttpFoundation/Request as class unlessBootstrap
implementsRequestClassInterface
which allows to return a more specific class. We could get rid ofAbstractBootstrap
then.May sound a bit complex but would remove the hard and non-explicit dependencies. I'd be happy to draft a patch if the direction becomes clear/ gets buy-in.
The text was updated successfully, but these errors were encountered: