-
Notifications
You must be signed in to change notification settings - Fork 71
Explicitly declare dependencies in composer.json #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
*@dev or dev-master? I had intentionally not done so as requirig a package that itself requires dev packes imho may cause troubles with minimum-stability. Or is that assumption wrong? |
Indeed, this may lead to problems. I would also prefer a reference to a stable version, but at the moment there are no tagged versions. I used |
As long as we don't have stable version I'd suggest leave it as is. Much easier to spot a missing dependency than trying to troubleshoot composer's error messages. As for |
The problem with the current state is, that you do not get a working library after An alternative could be to add |
As dev requirement is here the way to go. |
@marcj you've recently mentioned production deployment. How about declaring the current status to be a 1.0.0 across the packages and then take it from there? |
yes i wanted to do it, but doing currently some improvements which I want to include in the first version😊 In the next days this is happening |
Nice. I think we shouldn't merge anything else until then. |
Alright, I'm going to close this then and will adjust the composer.json straight with other changes. Thanks anyway guys! |
The HttpKernel bridge requires the
php-pm/php-pm
component to work.This change declares the mentioned dependency explicitly. Therefore, the development of the bridge is simplified as a
composer install
is enough to get started.