Skip to content

Used autoloaded AppKernel #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2016
Merged

Conversation

gnugat
Copy link

@gnugat gnugat commented Mar 18, 2016

Composer is perfectly capable of autoloading AppKernel (via the classmap autoloader), this is the approach used in the Symfony Standard Edition.

Composer is perfectly capable of autoloading AppKernel (via the `classmap` autoloader),
this is the approach used in the [Symfony Standard Edition](https://github.com/symfony/symfony-standard/blob/05bca699ef631d03d4b114b4366ad0c180b55ecb/composer.json#L8).
@gnugat gnugat force-pushed the autoloaded-app-kernel branch from ac25626 to f385366 Compare March 18, 2016 09:30
@@ -12,3 +12,12 @@ HttpKernel adapter for use of Symfony and Laravel frameworks with PHP-PM. See ht

composer require php-pm/httpkernel-adapter:dev-master

> **Note**: Make sure your `AppKernel` is autoloaded in your `composer.json`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth then to point out that it's not necessary in most cases or for symfony standard editions. Just to not confuse people

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll extend the note

marcj added a commit that referenced this pull request Mar 18, 2016
@marcj marcj merged commit 5ca05f8 into php-pm:master Mar 18, 2016
@marcj
Copy link
Member

marcj commented Mar 18, 2016

perfect thanks!

@gnugat gnugat deleted the autoloaded-app-kernel branch March 20, 2016 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants