Laravel fixes #39
Laravel fixes #39
Conversation
|
|
||
| if (is_a($this->application, '\Illuminate\Contracts\Http\Kernel')) { | ||
| $this->application->terminate($syRequest, $syResponse); | ||
| } |
There was a problem hiding this comment.
Does \Illuminate\Contracts\Http\Kernel not implementTerminableInterface?
There was a problem hiding this comment.
The only thing that Kernel implements, is just mentioned contract, that's why this one more case is required.
There was a problem hiding this comment.
Is there a reason why you don't go with $this->application instanceof \Illuminate\Contracts\Http\Kernel?
|
There is still some work needed to get authorization working properly, as it's singleton that stores user object as property. I tried to reset it in the same way as cookies and sessions, but there is some problem with that. |
|
Authorization is finally done - i have replaced SessionGuard class with more suitable version, that clears itself after every request. It would be cool to have such thing builtin into Laravel, but at the moment i couldn't find any better solution. |
|
I've tried your implementation buy I'm getting an error at line 124 of Illuminate/Auth/SessionGuard.php "Fatal error: Call to a member function get() on null". I'm using Laravel 5.2 if this gives you any hint. I'll tell you if I find more info or the solution. Feel free to ask if you need something. |
|
@duxet can you also add a reset headers in this PR? |
|
@duxet any chance to fix the open errors with this pr? |
|
@duxet ping. We need to close if if duxet is finishing this PR. |
|
Superseeded |
No description provided.