Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right padding when row too long #112

Merged
merged 2 commits into from
May 8, 2018
Merged

Conversation

AydinHassan
Copy link
Member

This PR fixes the negative right padding when the row is too long. We have a few options to improve this:

  1. Leave it as it is now where the text goes off the edge:

screen shot 2018-05-07 at 19 45 52

  1. split the row and put it on a new line

  2. throw an exception

What does everyone think? @Lynesth @mikeerickson

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #112 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
+ Coverage     96.86%   96.86%   +<.01%     
- Complexity      338      339       +1     
============================================
  Files            23       23              
  Lines          1051     1054       +3     
============================================
+ Hits           1018     1021       +3     
  Misses           33       33
Impacted Files Coverage Δ Complexity Δ
src/MenuStyle.php 96.01% <100%> (+0.06%) 61 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e9b55...aa4c9c8. Read the comment docs.

@Lynesth
Copy link
Collaborator

Lynesth commented May 8, 2018

I'd leave it with the text going off the edge for multiple reasons:

  1. It shouldn't happen that much.
  2. Breaking the word has to be done correctly, and that depends on language (english, spanish, etc) used and such. Too much work.
  3. Throwing an exception is a bit too much. The whole thing is still usable, just a little less beautilful.

@AydinHassan
Copy link
Member Author

agreed @Lynesth thanks!

@AydinHassan AydinHassan merged commit 9b15e16 into master May 8, 2018
@AydinHassan AydinHassan deleted the row-longer-than-width branch May 8, 2018 07:29
@AydinHassan AydinHassan added this to the 3.0 milestone May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants