Skip to content

Refactoring and such #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2018
Merged

Conversation

Lynesth
Copy link
Collaborator

@Lynesth Lynesth commented May 13, 2018

No description provided.

@AydinHassan AydinHassan merged commit ccea967 into php-school:split-item-builder May 13, 2018
@codecov-io
Copy link

codecov-io commented May 13, 2018

Codecov Report

Merging #128 into split-item-builder will increase coverage by 0.46%.
The diff coverage is 9.09%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             split-item-builder     #128      +/-   ##
========================================================
+ Coverage                 86.52%   86.98%   +0.46%     
+ Complexity                  423      419       -4     
========================================================
  Files                        26       26              
  Lines                      1291     1283       -8     
========================================================
- Hits                       1117     1116       -1     
+ Misses                      174      167       -7
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/SplitItem.php 0% <0%> (ø) 35 <2> (-1) ⬇️
src/CliMenu.php 85.1% <11.76%> (+0.29%) 89 <13> (-3) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32acc24...009cf60. Read the comment docs.

@AydinHassan
Copy link
Member

Thanks!

@AydinHassan AydinHassan added this to the 3.0 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants