Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when opening menu with no items #146

Merged
merged 1 commit into from
May 14, 2018
Merged

Conversation

AydinHassan
Copy link
Member

No description provided.

@AydinHassan AydinHassan requested a review from Lynesth May 14, 2018 15:47
@codecov-io
Copy link

codecov-io commented May 14, 2018

Codecov Report

Merging #146 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #146      +/-   ##
===========================================
+ Coverage     96.79%   96.8%   +<.01%     
- Complexity      428     429       +1     
===========================================
  Files            27      27              
  Lines          1312    1314       +2     
===========================================
+ Hits           1270    1272       +2     
  Misses           42      42
Impacted Files Coverage Δ Complexity Δ
src/CliMenu.php 98.31% <100%> (+0.01%) 91 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0abfd8...d10461d. Read the comment docs.

Copy link
Collaborator

@Lynesth Lynesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AydinHassan AydinHassan merged commit 974abe6 into master May 14, 2018
@AydinHassan AydinHassan deleted the menu-no-items branch May 14, 2018 15:54
@AydinHassan AydinHassan added this to the 3.0 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants