Fix infinite loop when no selectable items

[AydinHassan]

Resolves #144

[codecov-io]

Codecov Report

Merging #148 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
+ Coverage      96.8%   96.81%   +<.01%     
- Complexity      429      431       +2     
============================================
  Files            27       27              
  Lines          1314     1318       +4     
============================================
+ Hits           1272     1276       +4     
  Misses           42       42

Impacted Files	Coverage Δ	Complexity Δ
src/CliMenu.php	98.34% <100%> (+0.02%)	93 <0> (+2)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8184f...8158de5. Read the comment docs.

[Lynesth]

I don't think that works.
What if I add a new selectable item to the menu after I've opened it ?

I think it'd be better to check if we've looped once in the moveSelectionVertically and stop there. That way we don't have to verify items that populate the menu each time they get modified and it should be fast enough to not notice it.

[AydinHassan]

Okay. Will close this then.