Add setText to Items + small AsciiArt fix #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
============================================
+ Coverage 95.85% 95.96% +0.11%
- Complexity 425 431 +6
============================================
Files 27 27
Lines 1303 1315 +12
============================================
+ Hits 1249 1262 +13
+ Misses 54 53 -1
Continue to review full report at Codecov.
|
AydinHassan
requested changes
May 15, 2018
src/MenuItem/MenuItemInterface.php
Outdated
| /** | ||
| * Set the raw string of text | ||
| */ | ||
| public function setText(string $text) : void; |
There was a problem hiding this comment.
This doesn't need to be on the interface, when you are changing the text you will know what item you are dealing with and therefore will know the methods, no need to change this.
src/MenuItem/SplitItem.php
Outdated
| /** | ||
| * Nothing to set with SplitItem | ||
| */ | ||
| public function setText(string $text) : void |
There was a problem hiding this comment.
Can remove this after removing from the interface.
test/MenuItem/SplitItemTest.php
Outdated
| @@ -375,6 +375,14 @@ public function testGetTextThrowsAnException() : void | |||
|
|
|||
| (new SplitItem([]))->getText(); | |||
| } | |||
|
|
|||
| public function testSetTextThrowsAnException() : void | |||
AydinHassan
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to call
->setText()directly on items to modify their content on the fly.Can be usefull to do stuff like this:
Also fixes when right spaces on AsciiArt caused it to overflow and fallback to alt text (and a test to look after it).
Example: