Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 7.4 support #183

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Php 7.4 support #183

merged 5 commits into from
Dec 3, 2019

Conversation

AydinHassan
Copy link
Member

@AydinHassan AydinHassan commented Nov 30, 2019

  • Upgrade PHPUnit and fix some deprecations. PHPUnit 7 does not support PHP 7.4. I've had to expose a few properties because of deprecations regarding methods for accessing private properties in PHPUnit. Probably for the best.
  • Drop 7.1 testing from travis and add 7.4. We can still support 7.1 but we can't test on travis both 7.1 and 7.4 with the same version of PHPunit.

@codecov-io
Copy link

codecov-io commented Nov 30, 2019

Codecov Report

Merging #183 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
+ Coverage     93.25%   93.29%   +0.04%     
- Complexity      453      460       +7     
============================================
  Files            26       26              
  Lines          1393     1402       +9     
============================================
+ Hits           1299     1308       +9     
  Misses           94       94
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/LineBreakItem.php 100% <100%> (ø) 11 <1> (+1) ⬆️
src/MenuItem/SplitItem.php 100% <100%> (ø) 43 <1> (+1) ⬆️
src/CliMenu.php 93.04% <100%> (+0.1%) 105 <3> (+3) ⬆️
src/MenuItem/AsciiArtItem.php 100% <100%> (ø) 18 <2> (+2) ⬆️
src/Input/InputIO.php 96.87% <0%> (-0.08%) 25% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b16a29...42ab4a8. Read the comment docs.

Copy link
Member

@mikeymike mikeymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AydinHassan AydinHassan merged commit d80c749 into master Dec 3, 2019
@AydinHassan AydinHassan deleted the php-7.4 branch December 3, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants