Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial SplitItem + CheckableItem support #189

Merged
merged 4 commits into from
Dec 17, 2019

Conversation

jtreminio
Copy link
Contributor

Not yet ready to merge, pending unit tests and feedback.

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #189 into master will decrease coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
- Coverage     93.19%   93.05%   -0.15%     
- Complexity      486      491       +5     
============================================
  Files            27       27              
  Lines          1470     1483      +13     
============================================
+ Hits           1370     1380      +10     
- Misses          100      103       +3
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/CheckableItem.php 86.66% <ø> (ø) 19 <0> (ø) ⬇️
src/Builder/SplitItemBuilder.php 76.31% <100%> (+2.03%) 11 <1> (+1) ⬆️
src/MenuItem/SplitItem.php 97.67% <50%> (-2.33%) 45 <0> (+2)
src/Builder/CliMenuBuilder.php 84.07% <0%> (+0.4%) 67% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4db90...d25a1b3. Read the comment docs.

src/MenuItem/SplitItem.php Outdated Show resolved Hide resolved
@AydinHassan
Copy link
Member

Looks good to me - please add some tests and documentation 👍

@AydinHassan AydinHassan merged commit dcc4766 into php-school:master Dec 17, 2019
@AydinHassan
Copy link
Member

Thank you @jtreminio !

@jtreminio jtreminio deleted the feature/split-checkable-item branch December 17, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants