Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox + Radio item-level styling #204

Closed
wants to merge 4 commits into from

Conversation

jtreminio
Copy link
Contributor

Related to #203 and #200

  • Renames CheckableItem to CheckboxItem
  • Adds item-level styling (markers, item extra and display extra)
  • Item styles are passed down from parent menu, or use default values

This does not fix the nested-style issue from #201

@codecov-io
Copy link

Codecov Report

Merging #204 into master will increase coverage by 0.07%.
The diff coverage is 95.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
+ Coverage     93.91%   93.99%   +0.07%     
- Complexity      516      530      +14     
============================================
  Files            29       32       +3     
  Lines          1561     1648      +87     
============================================
+ Hits           1466     1549      +83     
- Misses           95       99       +4
Impacted Files Coverage Δ Complexity Δ
src/MenuStyle.php 96.99% <ø> (-0.29%) 70 <0> (-8)
src/Style/CheckboxStyle.php 100% <100%> (ø) 3 <3> (?)
src/Style/RadioStyle.php 100% <100%> (ø) 3 <3> (?)
src/Builder/SplitItemBuilder.php 83.92% <100%> (+6.42%) 14 <3> (+2) ⬆️
src/CliMenu.php 95.25% <100%> (+0.2%) 113 <4> (+4) ⬆️
src/MenuItem/RadioItem.php 100% <100%> (ø) 11 <7> (+1) ⬆️
src/MenuItem/ToggableTrait.php 100% <100%> (ø) 10 <6> (-1) ⬇️
src/MenuItem/CheckboxItem.php 100% <100%> (ø) 10 <10> (?)
src/MenuItem/SplitItem.php 100% <100%> (ø) 45 <0> (-2) ⬇️
src/Builder/CliMenuBuilder.php 82.72% <77.77%> (+0.99%) 70 <3> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e6a34...ed13965. Read the comment docs.

@jtreminio jtreminio mentioned this pull request Dec 19, 2019
@AydinHassan
Copy link
Member

Could you maybe rebase off master? I just cherry-picked the rename into master hoping it would just remove it from the PR but now it is conflicting 🙈

@AydinHassan
Copy link
Member

I've open #205 without the checkbox rename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants