SplitItemBuilder should reference menu styles #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AydinHassan
requested changes
Dec 19, 2019
| @@ -171,12 +158,12 @@ public function build() : SplitItem | |||
|
|
|||
| public function getCheckboxStyle() : CheckboxStyle | |||
| { | |||
| return $this->checkboxStyle; | |||
| return $this->menu->getCheckboxStyle(); | |||
| } | |||
|
|
|||
| public function setCheckboxStyle(CheckboxStyle $style) : self | |||
There was a problem hiding this comment.
Sorry and the modify* methods.
There was a problem hiding this comment.
SplitItemBuilder::setCheckboxStyle() is called from CliMenuBuilder::addSplitItem() so the split item can inherit the parent styles.
Codecov Report
@@ Coverage Diff @@
## item-style #208 +/- ##
================================================
- Coverage 92.73% 92.48% -0.26%
+ Complexity 561 559 -2
================================================
Files 30 30
Lines 1693 1689 -4
================================================
- Hits 1570 1562 -8
- Misses 123 127 +4
Continue to review full report at Codecov.
|
|
OK it works but I can't wrap my head around it. It's getting late here now anyway, need to sleep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #205