Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors for ItemStyles #230

Merged
merged 13 commits into from
Feb 15, 2020
Merged

Refactors for ItemStyles #230

merged 13 commits into from
Feb 15, 2020

Conversation

AydinHassan
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 15, 2020

Codecov Report

Merging #230 into master will decrease coverage by 1.02%.
The diff coverage is 73.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
- Coverage     93.09%   92.07%   -1.03%     
- Complexity      607      615       +8     
============================================
  Files            32       35       +3     
  Lines          1797     1854      +57     
============================================
+ Hits           1673     1707      +34     
- Misses          124      147      +23
Impacted Files Coverage Δ Complexity Δ
src/Style/SelectableStyle.php 100% <100%> (ø) 12 <2> (ø) ⬇️
src/Style/Exception/InvalidStyle.php 100% <100%> (ø) 3 <3> (?)
src/Style/DefaultStyle.php 100% <100%> (ø) 4 <4> (?)
src/MenuItem/RadioItem.php 100% <100%> (ø) 21 <2> (ø) ⬇️
src/MenuItem/MenuMenuItem.php 83.33% <100%> (+0.64%) 19 <3> (+1) ⬆️
src/MenuItem/CheckboxItem.php 100% <100%> (+7.27%) 20 <2> (ø) ⬇️
src/Style/Locator.php 100% <100%> (ø) 10 <10> (?)
src/MenuItem/SelectableItem.php 100% <100%> (ø) 16 <2> (ø) ⬇️
src/Util/ArrayUtils.php 100% <100%> (ø) 0 <0> (ø) ⬇️
src/Builder/CliMenuBuilder.php 70.86% <18.91%> (-6.31%) 75 <12> (-14)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2edd9d2...66392cb. Read the comment docs.

@AydinHassan AydinHassan merged commit d97347e into master Feb 15, 2020
@AydinHassan AydinHassan deleted the menu-item-style branch February 15, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants