Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding public functions addItems and setItems #86

Merged
merged 1 commit into from
May 1, 2018

Conversation

Lynesth
Copy link
Collaborator

@Lynesth Lynesth commented May 1, 2018

The addItems one is simply an extension of addItem.
The setItems one allow to completly change the content of the menu by replacing all items.

I use setItems mainly when showing paginated lists so that I just create new items and shove them inside the menu, without rebuild it entirely.

The addItems one is simply an extension of addItem.
The setItems one allow to completly change the content of the menu by replacing all items.
@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #86 into master will decrease coverage by 0.87%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #86      +/-   ##
===========================================
- Coverage     96.47%   95.6%   -0.88%     
- Complexity      278     282       +4     
===========================================
  Files            22      22              
  Lines           879     887       +8     
===========================================
  Hits            848     848              
- Misses           31      39       +8
Impacted Files Coverage Δ Complexity Δ
src/CliMenu.php 86.41% <0%> (-3.93%) 64 <4> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c883fb...b311969. Read the comment docs.

@Lynesth Lynesth changed the title Adding publc functions addItems and setItems Adding public functions addItems and setItems May 1, 2018
@AydinHassan
Copy link
Member

Thanks @Lynesth

@AydinHassan AydinHassan merged commit 3b64266 into php-school:master May 1, 2018
@AydinHassan AydinHassan added this to the 3.0 milestone May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants