Skip to content

Add a logger for the framework #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 6, 2020
Merged

Add a logger for the framework #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d7eb051
Add base test class to ease testing
AydinHassan Dec 6, 2020
980655b
Add Logger
AydinHassan Dec 6, 2020
16089df
Add psr/logger dep
AydinHassan Dec 6, 2020
9df1446
Logger config
AydinHassan Dec 6, 2020
8c1d641
Mock logger for testing
AydinHassan Dec 6, 2020
581419b
Container aware based test for pulling services from container and as…
AydinHassan Dec 6, 2020
9eeca6d
Test logger
AydinHassan Dec 6, 2020
9bbcaee
Add logging to initial code listener
AydinHassan Dec 6, 2020
e93a6a3
cs
AydinHassan Dec 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion app/config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

use Colors\Color;
use PhpSchool\PhpWorkshop\Listener\InitialCodeListener;
use PhpSchool\PhpWorkshop\Logger\Logger;
use Psr\Log\LoggerInterface;
use function DI\create;
use function DI\factory;
use Kadet\Highlighter\KeyLighter;
Expand Down Expand Up @@ -84,7 +86,17 @@

return [
'appName' => basename($_SERVER['argv'][0]),
'phpschoolGlobalDir' => sprintf('%s/.php-school', getenv('HOME')),
'currentWorkingDirectory' => function (ContainerInterface $c) {
return getcwd();
},
WorkshopType::class => WorkshopType::STANDARD(),
Psr\Log\LoggerInterface::class => function (ContainerInterface $c) {
$appName = $c->get('appName');
$globalDir = $c->get('phpschoolGlobalDir');

return new Logger("$globalDir/logs/$appName.log");
},
ExerciseDispatcher::class => function (ContainerInterface $c) {
return new ExerciseDispatcher(
$c->get(RunnerManager::class),
Expand Down Expand Up @@ -203,7 +215,7 @@

//Listeners
InitialCodeListener::class => function (ContainerInterface $c) {
return new InitialCodeListener(getcwd());
return new InitialCodeListener($c->get('currentWorkingDirectory'), $c->get(LoggerInterface::class));
},
PrepareSolutionListener::class => create(),
CodePatchListener::class => function (ContainerInterface $c) {
Expand Down
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"myclabs/php-enum": "^1.4",
"php-school/keylighter": "^0.8.4",
"nikic/php-parser": "^4.0",
"guzzlehttp/guzzle": "^7.2"
"guzzlehttp/guzzle": "^7.2",
"psr/log": "^1.1"
},
"require-dev": {
"composer/composer": "^2.0",
Expand Down
Loading