Skip to content

Fix type check + mkdir #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2021
Merged

Fix type check + mkdir #219

merged 1 commit into from
Jun 7, 2021
+2 −2

Conversation

@AydinHassan
Copy link
Member

ini_set only accepts strings 😱 - found only with a strict_types patch.

The other, the mkdir I think was wrong, but can you double check @mikeymike

@AydinHassan AydinHassan requested a review from mikeymike June 6, 2021 12:07
@AydinHassan AydinHassan mentioned this pull request Jun 6, 2021
Merged
@AydinHassan AydinHassan merged commit 738dd5c into master Jun 7, 2021
@AydinHassan AydinHassan deleted the patching-fixes branch June 7, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeymike mikeymike mikeymike approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AydinHassan @mikeymike