Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump veewee/xml requirement, extend build matrix #31

Merged
merged 1 commit into from
May 28, 2024

Conversation

lstrojny
Copy link
Contributor

Fixes #30

@lstrojny
Copy link
Contributor Author

@veewee changed the build matrix to have a better job description

What do you want to do about the errors?

This is from webmozart/assert, a transitive dependency from veewee/xml.

+'Deprecated: Use of "static" in callables is deprecated in /home/runner/work/wsdl-reader/wsdl-reader/vendor/webmozart/assert/src/Assert.php on line 1973\n
  1. Increase version in veewee/xml
  2. Require newer version in php-soap/wsdl-reader
  3. Ignore deprecation warnings in tests

This comes from phpunit/phpunit not being at least version 10 (transitive through php-soap/engine-integration-tests).

Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 2:
  - Element 'phpunit', attribute 'cacheDirectory': The attribute 'cacheDirectory' is not allowed.
  - Element 'phpunit', attribute 'requireCoverageMetadata': The attribute 'requireCoverageMetadata' is not allowed.
  - Element 'phpunit', attribute 'beStrictAboutCoverageMetadata': The attribute 'beStrictAboutCoverageMetadata' is not allowed.

  - Element 'source': This element is not expected.

Options:

  1. Bump to 10 in php-soap/engine-integration-tests
  2. Bump to 10 here

@lstrojny
Copy link
Contributor Author

(Fixed the boolean evaluation issue)

@veewee
Copy link
Member

veewee commented May 28, 2024

@lstrojny

Bumping to phpunit 10 would be some work in verious repos I suppose. It's on my radar, but I'm trying to get some other things (soap encoding) ready first.

Maybe better to provide alternative ranges for both phpunit and assert inside this package's composer.json for now?

@lstrojny
Copy link
Contributor Author

@veewee bumped the relevant dependencies

@lstrojny
Copy link
Contributor Author

Needed to bump phpunit to 10.1, not 10.0. Let's see …

@veewee
Copy link
Member

veewee commented May 28, 2024

Looks good, thanks for the effort (again) !

@veewee veewee merged commit 399615a into php-soap:main May 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add additional method metadata" breaks compatibility with veewee/xml <3.0.0
2 participants