Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm5 support #9

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Psalm5 support #9

merged 1 commit into from
Nov 30, 2022

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Nov 30, 2022

Psalm v5 is out!

This PR contains:

  • fixes for psalm v5 (it now has immutable non-cloneable union types)

PSL itself cannot use psalm5 unless roave/infection-static-analysis-plugin supports psalm v5.

There are 30-ish new psalm warnings in psalm v5 atm which need to be addressed in the psl package.

@Ocramius
Copy link

The infection plugin is updated, BTW 👍

@veewee
Copy link
Collaborator Author

veewee commented Nov 30, 2022

Cool, Thanks!
The psalm 5 issues in here and PSL look good to go to me as well.
Let's see if @azjezz has something to add.

@azjezz
Copy link
Contributor

azjezz commented Nov 30, 2022

lgtm ✅

@veewee veewee merged commit bf223f6 into php-standard-library:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants