Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot API 6.0 #1318

Merged
merged 16 commits into from
Apr 24, 2022
Merged

Bot API 6.0 #1318

merged 16 commits into from
Apr 24, 2022

Conversation

TiiFuchs
Copy link
Member

No description provided.

TiiFuchs
TiiFuchs commented Apr 17, 2022
View reviewed changes
src/Entities/Factory.php Outdated Show resolved Hide resolved
@TiiFuchs TiiFuchs mentioned this pull request Apr 17, 2022
Closed
9 tasks
TiiFuchs added 11 commits April 17, 2022 12:26
@TiiFuchs
Added test for returning subentities on arrays
406b72b
@TiiFuchs
Added the class SentWebAppMessage and the method answerWebAppQuery fo…
7ca60aa 
…r sending an answer to a Web App query, which originated from an inline button of the 'web_app' type.
@TiiFuchs
Added the class WebAppData and the field web_app_data to the class Me…
5c9fd8b 
…ssage.
@TiiFuchs
Added the class MenuButton and the methods setChatMenuButton and getC…
545e002 
…hatMenuButton for managing the behavior of the bot's menu button in private chats.
@TiiFuchs
Fixed Tests for InlineKeyboardButton since we changed the exception m…
44ab572 
…essage
@TiiFuchs
Added the class ChatAdministratorRights and the methods setMyDefaultA…
7c22f26 
…dministratorRights and getMyDefaultAdministratorRights for managing the bot's default administrator rights.
@TiiFuchs
Added the field last_synchronization_error_date to the class WebhookI…
8bca196 
…nfo.
@TiiFuchs
Renamed the field can_manage_voice_chats to can_manage_video_chats in…
048405b 
… the class ChatMemberAdministrator. The old field will remain temporarily available
@TiiFuchs
Renamed the fields voice_chat_scheduled, voice_chat_started, voice_ch…
260cd05 
…at_ended, and voice_chat_participants_invited to video_chat_scheduled, video_chat_started, video_chat_ended, and video_chat_participants_invited in the class Message. The old fields will remain temporarily available.

Old classes are deprecated
@TiiFuchs
Re-added voide entities to message object
8c61b78
@TiiFuchs
Added Changelog and updated Bot API Version in README
d372bb2
@TiiFuchs TiiFuchs self-assigned this Apr 17, 2022
@TiiFuchs TiiFuchs requested a review from noplanman April 17, 2022 18:07
@TiiFuchs TiiFuchs linked an issue Apr 17, 2022 that may be closed by this pull request
Bot API 6.0 #1317
Closed
9 tasks
@TiiFuchs TiiFuchs marked this pull request as ready for review April 17, 2022 18:10
noplanman
noplanman reviewed Apr 18, 2022
View reviewed changes
src/Entities/Factory.php Outdated Show resolved Hide resolved
src/Request.php Outdated Show resolved Hide resolved
@noplanman
Copy link
Member

This is looking good, nice work 👍

Last thing missing is the DB migrations to rename all the voice_chat -> video_chat fields. And to add the new WebApp fields.

@TiiFuchs You wanna give it a go?

TiiFuchs and others added 2 commits April 19, 2022 08:38
@TiiFuchs
Revert Auto format changes
af09462
@TiiFuchs @noplanman
Make use of early returns
464efa2 
Co-authored-by: Armando Lüscher <armando@noplanman.ch>
@TiiFuchs
Copy link
Member Author

This is looking good, nice work 👍

Last thing missing is the DB migrations to rename all the voice_chat -> video_chat fields. And to add the new WebApp fields.

@TiiFuchs You wanna give it a go?

I always forget about the database >.<"

I can try this evening, yeah. :)

@TiiFuchs
Copy link
Member Author

@TiiFuchs You wanna give it a go?

@noplanman Done. Did I miss anything?

@TiiFuchs
Copy link
Member Author

I think we need to check createResultObject and createResultObjects

@TiiFuchs
Copy link
Member Author

I think we need to check createResultObject and createResultObjects

Yup there was stuff missing. I added that.
Should be finished now.

@TiiFuchs TiiFuchs merged commit 1c6c9aa into develop Apr 24, 2022
@noplanman noplanman deleted the api-6.0 branch April 24, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noplanman noplanman noplanman left review comments

Assignees

@TiiFuchs TiiFuchs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bot API 6.0
2 participants
@TiiFuchs @noplanman