Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot API 6.4-6.7 #1389

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Bot API 6.4-6.7 #1389

merged 7 commits into from
Apr 26, 2023

Conversation

noplanman
Copy link
Member

@noplanman noplanman commented Apr 25, 2023

? !
Type feature / improvement
BC Break no
Fixed issues n/a

Summary

The long awaited PR to update to the latest Bot API 6.7 🎉

@TiiFuchs Feedback welcome of course.

I'm wondering if the new entity classes should be organised differently. Like all the Bot* into a Bot folder and InlineQuery* ones into the existing InlineQuery one?

Also, I've introduced a public static variable Entity::$fixThumbnailRename which is true by default, which should make sure that bots using the old thumb field and method calls don't suddenly break. It converts all found thumb fields and method names to thumbnail.

Also notice the improved result objects returned in the ServerResponse object.

I've not done extensive testing yet.

@noplanman noplanman requested a review from TiiFuchs April 25, 2023 01:26
Copy link
Member

@TiiFuchs TiiFuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my respect and gratitude.
I hereby approve thee changes.

@TiiFuchs TiiFuchs merged commit ce83ece into develop Apr 26, 2023
@TiiFuchs TiiFuchs deleted the api-6.4-6.7 branch April 26, 2023 21:32
@jacklul
Copy link
Collaborator

jacklul commented Aug 6, 2023

Seems like changes about thumb_url -> thumbnail_url were not applied to InlineQueryResultPhoto and InlineQueryResultVideo comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants