upsome for todo

php-toolkit · Sep 4, 2021 · e884b68 · e884b68
1 parent d354fed
commit e884b68
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/src/AbstractFlags.php b/src/AbstractFlags.php
@@ -141,11 +141,19 @@ abstract class AbstractFlags implements ParserInterface
      */
     protected $settings = [
         'hasShorts'      => false,
+        // some setting for render help
         'argNameLen'     => 12,
         'optNameLen'     => 12,
         'descNlOnOptLen' => self::OPT_MAX_WIDTH,
     ];
 
+    /**
+     * Delay call validators after parsed. TODO
+     *
+     * @var bool
+     */
+    protected $delayValidate = false;
+
     // -------------------- settings for parse option --------------------
 
     /**

diff --git a/src/Contract/ValueInterface.php b/src/Contract/ValueInterface.php
@@ -7,7 +7,12 @@
  */
 interface ValueInterface
 {
-    public function setValue();
+    /**
+     * @param mixed $value
+     *
+     * @return mixed
+     */
+    public function setValue($value);
 
     public function getValue();
 }
diff --git a/src/SFlags.php b/src/SFlags.php
@@ -36,12 +36,6 @@ class SFlags extends AbstractFlags
      */
     private static $std;
 
-    /**
-     * @var callable
-     * @psalm-var callable(mixed $value, string $type): mixed
-     */
-    protected $valueFilter;
-
     // ------------------------ opts ------------------------
 
     /**
@@ -804,12 +798,4 @@ public function getOptDefines(): array
     {
         return $this->optDefines;
     }
-
-    /**
-     * @param callable $valueFilter
-     */
-    public function setValueFilter(callable $valueFilter): void
-    {
-        $this->valueFilter = $valueFilter;
-    }
 }