Cassette Name Passed to substr May be Null

[chrisguitarguy]

phpunit-testlistener-vcr/src/VCRTestListener.php

Lines 49 to 51 in 7ef7225

	if (substr($cassetteName, -5) === '.json') {
	VCR::configure()->setStorage('json');
	}

If, for instance, the test doesn't have a @vcr annotation, that value (from array_pop($parsed)) may be null. This causes a TypeError due to the strict_types declaration.

Probably could be fixed by moving the empty($cassetteName) check before the check for a .json extension.

phpunit-testlistener-vcr/src/VCRTestListener.php

Lines 53 to 55 in 7ef7225

	if (empty($cassetteName)) {
	return;
	}

[renatomefi]

Hello @chrisguitarguy thanks for the report and the findings!

Would you be willing to open a PR? We can check together the tests to ensure BC!

Thanks again

[chrisguitarguy]

Done @renatomefi !