Fix/general improvements #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatomefi
force-pushed
the
fix/general-improvements
branch
from
c318133 to
dfab168
Compare
adri
reviewed
Oct 19, 2016
| * @vcr unittest_annotation_test_auto_generated.yml | ||
| */ | ||
| public function testInterceptsWithAnnotationsAutoGenerated() |
There was a problem hiding this comment.
Not sure if it needs a test because this is intensively tested within php-vcr.
But keeping it is ok, I just wonder if we don't delete the fixture file in the test or use vfsStream that we can get false-positives.
There was a problem hiding this comment.
Indeed, I'll remove it from here and work on it better when I integrate Travis to this project in a future PR! :)
adri
requested changes
Oct 19, 2016
| /** | ||
| * @vcr unittest_annotation_test.yml | ||
| */ | ||
| public function testInterceptsWithAnnotationsAndFileExtension() |
|
@adri fixed! |
Closed
|
Very nice man! Just having the conflict now oO |
|
Will fix during lunch! :) |
…vements # Conflicts: # tests/PHPUnit/Util/Log/VCRTest.php
|
@adri updated! :) |
adri
approved these changes
Oct 24, 2016
GaryJones
reviewed
Feb 16, 2017
| <listeners> | ||
| <listener class="PHPUnit_Util_Log_VCR" file="vendor/php-vcr/phpunit-testlistener-vcr/PHPUnit/Util/Log/VCR.php" /> | ||
| </listeners> | ||
| ```yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.