Refactored package to use PHPUnit 6 and namespaces #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using projects that require PHPUnit 6 (with namespaces), this library causes conflicts. This PR addresses this by refactoring the code to use the new version, and moves files to standard folders (
src/
with PSR4 autoloading). This fixes #20.This version is a BC break, so a new major version bump would be required (from 2.0 to 3.0).
PHPUnit/Util/Log/VCR.php
has been renamedsrc/VCRTestListener.php
(according to common practices). Unfortunately Git didn't correctly pick up the move, therefore it looks like the previous file has been deleted, and the new one was created. Contents are basically the same, with the refactored use of namespaces anduse
statements.For end users, upgrading should be as simple as copy/pasting the new configuration in their
phpunit.xml
files, but I can write an upgrade guide.As I'm seeing low activity around this library (and unfortunately around PHP-VCR as well), I'm prepared to release my forked version, even though I would much rather contribute to the original project.