Skip to content

Make compatible with PHPUnit 7 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2018
Merged

Make compatible with PHPUnit 7 #26

merged 2 commits into from
Jun 22, 2018

Conversation

Sevavietl
Copy link
Contributor

PHPUnit 7 uses interfaces with "strict" typing and Throwable type-hint for exceptions.

These changes break backwards compatibility, so, I guess, they deserve new release.

Thank you in advance.

@stijink
Copy link

stijink commented Feb 28, 2018

Would be very nice :-)

@jacques
Copy link

jacques commented Mar 1, 2018

Any idea when this can be merged?

@stijink
Copy link

stijink commented Mar 5, 2018

I think the "challange" is that PHPUnit 7 requires at least PHP 7.1. This package currently is supporting PHP 7.0. And that's why the tests are failing. The author now needs to decide how to handle this situation :-)

@moufmouf
Copy link

moufmouf commented Apr 17, 2018

IMHO, this PR is perfect. You can't have a package that is both compatible with PHPUnit 6 and 7 at the same time.
What the author could do is merge his PR in a new 3.1 branch.
That way, users requiring php-vcr/phpunit-testlistener-vcr: ^3.0 will be automatically upgraded to 3.1 only if they switch to PHPUnit 7 / PHP 7.1

@mattias-persson mattias-persson mentioned this pull request Apr 18, 2018
@njbarrett
Copy link

I would like to see this merged also

@jacques
Copy link

jacques commented Jun 21, 2018

Any ETA on when this will be merged in?

@renatomefi renatomefi changed the base branch from master to 3.1 June 22, 2018 07:43
@renatomefi renatomefi merged commit f004141 into php-vcr:3.1 Jun 22, 2018
@renatomefi
Copy link
Member

renatomefi commented Jun 22, 2018

Sorry for the delay every1, making the release soon!

@renatomefi
Copy link
Member

@Sevavietl @stijink @moufmouf @njbarrett @jacques @hniirane @mattias-persson
Thanks for all opinions, code and ideas!

Now if you have php 7.0 you stick with ^3.0.0
If you have php 7.1 you can update to ^3.1

  • Note the semantic versioning is a bit broken, but I hope this make it easier for everyone to udpate

I've released 3.1 with this compatibility and 3.2 with some code love, please give it a test and let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants