-
Notifications
You must be signed in to change notification settings - Fork 50
Make compatible with PHPUnit 7 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would be very nice :-) |
Any idea when this can be merged? |
I think the "challange" is that PHPUnit 7 requires at least PHP 7.1. This package currently is supporting PHP 7.0. And that's why the tests are failing. The author now needs to decide how to handle this situation :-) |
IMHO, this PR is perfect. You can't have a package that is both compatible with PHPUnit 6 and 7 at the same time. |
I would like to see this merged also |
Any ETA on when this will be merged in? |
Sorry for the delay every1, making the release soon! |
@Sevavietl @stijink @moufmouf @njbarrett @jacques @hniirane @mattias-persson Now if you have php 7.0 you stick with ^3.0.0
I've released 3.1 with this compatibility and 3.2 with some code love, please give it a test and let me know |
PHPUnit 7 uses interfaces with "strict" typing and
Throwable
type-hint for exceptions.These changes break backwards compatibility, so, I guess, they deserve new release.
Thank you in advance.