Skip to content

Move the Empty Check on $cassetteName Up #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2018
Merged

Move the Empty Check on $cassetteName Up #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6009d8
Add a Failing Test Case for Tests with No vcr Annotation
chrisguitarguy Jul 3, 2018
a56c7e2
Move the `empty($cassetteName)` Check Up
chrisguitarguy Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/VCRTestListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ public function startTest(Test $test): void
$parsed = self::parseDocBlock($docBlock, '@vcr');
$cassetteName = array_pop($parsed);

if (empty($cassetteName)) {
return;
}

// If the cassette name ends in .json, then use the JSON storage format
if (substr($cassetteName, -5) === '.json') {
VCR::configure()->setStorage('json');
}

if (empty($cassetteName)) {
return;
}

VCR::turnOn();
VCR::insertCassette($cassetteName);
}
Expand Down
8 changes: 8 additions & 0 deletions tests/VCRTestListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ public function testInterceptsWithAnnotationsWhenUsingDataProvider(int $dummyVal
$this->assertEquals('This is a annotation test dummy.', $result, 'Call was not intercepted (using annotations with data provider).');
}

/**
* @group https://github.com/php-vcr/phpunit-testlistener-vcr/issues/29
*/
public function testNoVcrAnnotationRunsSuccessfulAndDoesNotProduceWarnings()
{
$this->assertTrue(true, 'just adding an assertion here');
}

public function dummyDataProvider(): array
{
return [
Expand Down