-
Notifications
You must be signed in to change notification settings - Fork 50
Support PHP 8 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 8 #38
Conversation
Is this package still maintained? It's such a pity that nobody approves this merge request. |
Please merge and tag a new release 🙏 |
Any chance to tag release with php 8 support? |
@dborsatto @JeroenVanOort @K-Phoen @renatomefi y'all are members of @php-vcr, can you please take a look at this. |
@dborsatto @JeroenVanOort @K-Phoen @renatomefi any chances that this can be merged and a new release created? |
I personally was added to the php-vcr org 4-5 years ago because I submitted a PR, but I wouldn't call myself a maintainer, and tbh I haven't even used the library since 2019. I actually just removed myself from the org because it doesn't feel like I should be a part of it 🤷♂️ |
@JeroenVanOort @K-Phoen @renatomefi any chances that this can be merged and a new release created? |
I'm not using this package myself anymore (except some legacy stuff, moved to httplug & middlewares). |
Hey guys We are a company based in Sydney, AU, and use this package quite a lot. Please feel free to use our fork. We might change the namespace if this package is officially unmtaintained now. |
@JeroenVanOort @K-Phoen @renatomefi any chances that this can be merged and a new release created? |
@higidi are you able to merge this? |
Any updates about that ? |
Maybe this should be archived and a link to https://github.com/CoverGenius/phpunit-testlistener-vcr be added because it seems they are actively supporting it in that fork. |
Basically the same as #37, but tests against PHP 8 on Bionic (where the package exists), and also allows newer
phpunit
(which is required for PHP 8). Thanks.