Skip to content

Support PHP 8 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Support PHP 8 #38

merged 2 commits into from
Oct 29, 2024

Conversation

kornrunner
Copy link
Contributor

Basically the same as #37, but tests against PHP 8 on Bionic (where the package exists), and also allows newer phpunit (which is required for PHP 8). Thanks.

@davide-casiraghi
Copy link

davide-casiraghi commented Feb 12, 2021

Is this package still maintained? It's such a pity that nobody approves this merge request.

@igaster
Copy link

igaster commented May 7, 2021

Please merge and tag a new release 🙏

@glebLaModa
Copy link

Any chance to tag release with php 8 support?

@abraham abraham mentioned this pull request Apr 2, 2022
@abraham
Copy link

abraham commented Apr 2, 2022

@dborsatto @JeroenVanOort @K-Phoen @renatomefi y'all are members of @php-vcr, can you please take a look at this.

@jacques
Copy link

jacques commented Jun 8, 2022

@dborsatto @JeroenVanOort @K-Phoen @renatomefi any chances that this can be merged and a new release created?

@dborsatto
Copy link
Contributor

I personally was added to the php-vcr org 4-5 years ago because I submitted a PR, but I wouldn't call myself a maintainer, and tbh I haven't even used the library since 2019.

I actually just removed myself from the org because it doesn't feel like I should be a part of it 🤷‍♂️

@jacques
Copy link

jacques commented Jul 16, 2022

@JeroenVanOort @K-Phoen @renatomefi any chances that this can be merged and a new release created?

@janvernieuwe
Copy link

I'm not using this package myself anymore (except some legacy stuff, moved to httplug & middlewares).
But if there are no maintainers (no, i don't want to maintain this either) it would probably better to archive this project so that it's clear that it's unmaintained and ppl don't get their hopes up.

@specialtactics
Copy link

Hey guys

We are a company based in Sydney, AU, and use this package quite a lot. Please feel free to use our fork.
https://github.com/CoverGenius/phpunit-testlistener-vcr

We might change the namespace if this package is officially unmtaintained now.

@jacques
Copy link

jacques commented Oct 7, 2022

@JeroenVanOort @K-Phoen @renatomefi any chances that this can be merged and a new release created?

@nicodemuz
Copy link

@higidi are you able to merge this?

@kmelkez
Copy link

kmelkez commented Oct 29, 2024

Any updates about that ?

@pelletiermaxime
Copy link

Maybe this should be archived and a link to https://github.com/CoverGenius/phpunit-testlistener-vcr be added because it seems they are actively supporting it in that fork.

@higidi higidi merged commit e57a97f into php-vcr:master Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.