Rewrite and document git log parsing #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Merge. Let me know if are any regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My rewrite of
revcheck.php3 years ago used a bit of magic. It relied upon some context-free characteristics ofgit logformat that still holds, but is fragile, and also interact badly with[skip-revcheck]logic on borderline cases (sequential, misaligned). This rewrite makes the code more stateful and more precise, to better document what data is extracted from each part of the log, and in what order.Tested on
de,es,fr,it,ja,pl,pt_BR,ro,ru,tr,uk,zhwith no regressions. This is the last push before finally tackling the root cause of issue 133.Reviews and comments welcome. I plan to merge this in about one week.