Replace each() with foreach in asXML() example #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@php-pulls merge |
php-pulls
pushed a commit
that referenced
this pull request
Mar 7, 2020
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349324 c90b9560-bf6c-de11-be94-00142212c4b1
php-pulls
pushed a commit
that referenced
this pull request
May 17, 2020
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349902 c90b9560-bf6c-de11-be94-00142212c4b1
Firehed
added a commit
to Firehed/doc-en
that referenced
this pull request
Mar 18, 2021
The documented parameters differ from the names exposed in reflection/source code. Now that named parameters are supported in PHP 8, this discrepancy is confusing and impactful.
```
$ php --rf fgetcsv
Function [ <internal:standard> function fgetcsv ] {
- Parameters [5] {
Parameter #0 [ <required> $stream ]
Parameter php#1 [ <optional> ?int $length = null ]
Parameter php#2 [ <optional> string $separator = "," ]
Parameter php#3 [ <optional> string $enclosure = "\"" ]
Parameter php#4 [ <optional> string $escape = "\\" ]
}
- Return [ array|false ]
}
```
php-pulls
pushed a commit
that referenced
this pull request
Mar 18, 2021
The documented parameters differ from the names exposed in reflection/source code. Now that named parameters are supported in PHP 8, this discrepancy is confusing and impactful.
```
$ php --rf fgetcsv
Function [ <internal:standard> function fgetcsv ] {
- Parameters [5] {
Parameter #0 [ <required> $stream ]
Parameter #1 [ <optional> ?int $length = null ]
Parameter #2 [ <optional> string $separator = "," ]
Parameter #3 [ <optional> string $enclosure = "\"" ]
Parameter #4 [ <optional> string $escape = "\\" ]
}
- Return [ array|false ]
}
```
Closes GH-493.
derickr
added a commit
that referenced
this pull request
Aug 12, 2022
tiffany-taylor
added a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Nov 9, 2022
tiffany-taylor
pushed a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Jan 16, 2023
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
Girgias
added a commit
that referenced
this pull request
Sep 11, 2024
…3485) * Solr 2.7.0: SolrQuery::setHighlightQuery * Apply suggestions from code review #1 formatting suggestions from CR Co-authored-by: Gina Peter Banyard <girgias@php.net> * SolrQuery::setHighlightQuery: clarification and rewording * SolrQuery: remove entities file * Whitespaces --------- Co-authored-by: Gina Peter Banyard <girgias@php.net>
Girgias
pushed a commit
that referenced
this pull request
Feb 7, 2025
This makes the example executable. Remove superfluous callable examples. --------- Co-authored-by: Arthur <arthur.tkachenko@giftcardsgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.