Skip to content

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Dec 25, 2023

Added additional section headers above each set of constants to clarify what they are and how to access them, clarified which functions the buffer control flags have an effect on, and added a section for the missing handler status constants.

These last three constants include PHP_OUTPUT_HANDLER_PROCESSED which is returned by ob_get_status() but it is, IMO by mistake, not exposed to userland (PR submitted php/php-src/pull/13019).

The other two, PHP_OUTPUT_HANDLER_STARTED and PHP_OUTPUT_HANDLER_DISABLED, are mentioned as needing documentation in #2747 .

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants