Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated mysqli_ping() #3847

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Deprecated mysqli_ping() #3847

merged 2 commits into from
Oct 16, 2024

Conversation

kamil-tekiela
Copy link
Member

No description provided.

@kamil-tekiela kamil-tekiela added this to the PHP 8.4 milestone Oct 7, 2024
Girgias
Girgias approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the thread_id() change slip in due to some other PR?

@kamil-tekiela
Copy link
Member Author

Did the thread_id() change slip in due to some other PR?

I found it while making this PR and decided to include it in. Would you like me to commit it separately?

cmb69
cmb69 reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

In my opinion the unrelated fix can be commited here (no need for a separate PR).

reference/mysqli/mysqli/ping.xml Outdated Show resolved Hide resolved
@kamil-tekiela @cmb69
Update reference/mysqli/mysqli/ping.xml
769096e 
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@Girgias
Copy link
Member

Girgias commented Oct 12, 2024

Did the thread_id() change slip in due to some other PR?

I found it while making this PR and decided to include it in. Would you like me to commit it separately?

I don't mind, just wanted to make sure it was intentional :)

@jimwins jimwins merged commit 1afd358 into php:master Oct 16, 2024
2 checks passed
@KentarouTakeda KentarouTakeda mentioned this pull request Nov 12, 2024
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.4
Development

Successfully merging this pull request may close these issues.
4 participants
@kamil-tekiela @Girgias @cmb69 @jimwins