Clarify strcspn() example
#3892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Oct 22, 2024
Using human readable words for the `$characters` parameter creates confusion, as each character is used separately in the function.
wouterj
force-pushed
the
strcspn-clarify-example
branch
from
74d9c95 to
7073c93
Compare
|
Example added, as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using human readable words for the
$charactersparameter creates confusion, as each character is used separately in the function.I propose to simplify the example by using one character when focusing on the standard behavior or the offset/length parameters. And modifying the example to use multiple consecutive characters instead of a real word (with duplicate characters).