Document XML_OPTION_PARSE_HUGE #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Oct 22, 2024
Comment on lines
67
to
68
| This option should only be enabled when the document size is | ||
| bounded. |
There was a problem hiding this comment.
Probably clear enough, but maybe hint at DoS?
| </term> | ||
| <listitem> | ||
| <simpara> | ||
| Available as of PHP 8.4.0. |
There was a problem hiding this comment.
I have no idea whether libexpat is still properly supported, but if it is, we should clarify here (or maybe below) that the constant is only relevant for libxml2. I'm also not sure whether PHP 7.0 still supported libxml2 < 2.7.0, and if so, what would happen there (would basically XML_OPTION_PARSE_HUGE be enabled by default, and could not be disabled?)
There was a problem hiding this comment.
you are right; why does it have to be so complex :(
There was a problem hiding this comment.
Just checked, PHP 7 supports libxml2 2.6.11
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.