Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] Add manual for grapheme_str_split function #3956

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

youkidearitai
Copy link
Contributor

@youkidearitai youkidearitai commented Oct 29, 2024

Add grapheme_str_split function.

RFC:

ref: #3872

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

reference/intl/grapheme/grapheme-str-split.xml Outdated Show resolved Hide resolved
reference/intl/grapheme/grapheme-str-split.xml Outdated Show resolved Hide resolved
reference/intl/grapheme/grapheme-str-split.xml Outdated Show resolved Hide resolved
reference/intl/grapheme/grapheme-str-split.xml Outdated Show resolved Hide resolved
reference/intl/grapheme/grapheme-str-split.xml Outdated Show resolved Hide resolved
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Besides some minor issue, this looks good to me.

reference/strings/functions/str-split.xml Outdated Show resolved Hide resolved
reference/intl/grapheme/grapheme-str-split.xml Outdated Show resolved Hide resolved
reference/intl/grapheme/grapheme-str-split.xml Outdated Show resolved Hide resolved
youkidearitai and others added 4 commits October 30, 2024 07:25
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@cmb69 cmb69 merged commit 31e3015 into php:master Oct 30, 2024
2 checks passed
@cmb69
Copy link
Member

cmb69 commented Oct 30, 2024

Thank you!

Girgias added a commit that referenced this pull request Oct 30, 2024
Also use simpara instead of para tags

Follow-up to GH-3956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants