Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.4] Add errors for GD functions #3962

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[PHP 8.4] Add errors for GD functions #3962

merged 2 commits into from
Oct 29, 2024

Conversation

saundefined
Copy link
Member

No description provided.

@saundefined saundefined added this to the PHP 8.4 milestone Oct 29, 2024
@saundefined saundefined mentioned this pull request Oct 29, 2024
Open
cmb69
cmb69 reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Maybe @devnexen can have a look?

reference/image/functions/imageavif.xml Outdated Show resolved Hide resolved
reference/image/functions/imageavif.xml Outdated Show resolved Hide resolved
reference/image/functions/imagefilter.xml Outdated Show resolved Hide resolved
reference/image/functions/imagescale.xml Outdated Show resolved Hide resolved
@saundefined @cmb69
Apply suggestions from code review
1cbdad1 
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
devnexen
devnexen approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmb69
cmb69 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@saundefined saundefined merged commit ccd3e68 into php:master Oct 29, 2024
2 checks passed
@saundefined saundefined deleted the php84-gd-errors branch October 29, 2024 17:14
@KentarouTakeda KentarouTakeda mentioned this pull request Nov 7, 2024
Open
48 tasks
@Ippey Ippey mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@saundefined @cmb69 @devnexen