Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP-8.4: Document http_(get|clear)_last_response_headers() functions #4034

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 11, 2024

No description provided.

@Girgias Girgias added this to the PHP 8.4 milestone Nov 11, 2024
@Girgias Girgias requested a review from cmb69 November 11, 2024 03:13
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Found a typo; otherwise looks good.

<refentry xml:id="function.http-get-last-response-headers" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">
<refnamediv>
<refname>http_get_last_response_headers</refname>
<refpurpose>Retrieve lastest HTTP response headers</refpurpose>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<refpurpose>Retrieve lastest HTTP response headers</refpurpose>
<refpurpose>Retrieve last HTTP response headers</refpurpose>

[1]=>
string(35) "Date: Sat, 12 Apr 2008 17:30:38 GMT"
[2]=>
string(29) "Server: Apache/2.2.3 (CentOS)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did copy this over from the $http_response_headers probably should check again

@Girgias Girgias merged commit 3f1cd51 into php:master Nov 11, 2024
2 checks passed
@Girgias Girgias deleted the http-last-request branch November 11, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants