Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4: Document type widening of mode param of round() #4107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 20, 2024

@haszi not sure if I should use a <constant> tag here for linking, but <enumidentifier> is not allowed... I could use <code>, however.

@haszi
Copy link
Contributor

haszi commented Nov 24, 2024

@haszi not sure if I should use a <constant> tag here for linking, but <enumidentifier> is not allowed... I could use <code>, however.

Semantically, <constant> seems to be much closer to what we want here.

PHP isn't the only language to allow enums as default values so the <enumidentifier> not being allowed seems like an oversight in the DocBook spec. :-)

@haszi
Copy link
Contributor

haszi commented Nov 24, 2024

<constant> won't link to an enum. I'm not sure how to handle the linking though.

@Girgias
Copy link
Member Author

Girgias commented Nov 24, 2024

<constant> won't link to an enum. I'm not sure how to handle the linking though.

I suppose one could add a role attribute to the constant tag, e.g. <constant role="enum"> to link enum cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants