Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks reflection #4110

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Hooks reflection #4110

wants to merge 4 commits into from

Conversation

Crell
Copy link
Contributor

@Crell Crell commented Nov 20, 2024

New PR, includes #4039, which generates the stubs. Still WIP.

Resolves #4039.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, seems like the output from gen_stub is wrong, that's good to know :|

But thanks for working on it!

reference/reflection/reflectionproperty/gethook.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionproperty/gethook.xml Outdated Show resolved Hide resolved
Comment on lines +43 to +65

<refsect1 role="changelog">
&reftitle.changelog;
<informaltable>
<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.4.0</entry>
<entry>
Added
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
</refsect1>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't add a changelog for when we add the method, that's handled by the version.xml file :)

reference/reflection/reflectionproperty/gethook.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionproperty/gethooks.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionproperty/getrawvalue.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionproperty/hashook.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionproperty/hashooks.xml Outdated Show resolved Hide resolved
Crell and others added 2 commits November 20, 2024 11:13
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants