Skip to content

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Nov 24, 2024

Remove the "Other filter" section

Remove the "Other filter" section
@Girgias Girgias requested a review from cmb69 November 24, 2024 02:23
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but what I think this page still lacks is the information about the callable signature. The example doesn't specify parameter type but makes assumption that it's always string. Is that true?

@Girgias
Copy link
Member Author

Girgias commented Nov 24, 2024

Good, but what I think this page still lacks is the information about the callable signature. The example doesn't specify parameter type but makes assumption that it's always string. Is that true?

Yeah it is always a string: https://3v4l.org/J6k7r

Girgias and others added 2 commits November 24, 2024 03:10
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
@Girgias Girgias merged commit 2f3041d into php:master Nov 24, 2024
2 checks passed
@Girgias Girgias deleted the filter-more branch November 24, 2024 03:22
@kamil-tekiela
Copy link
Member

Good, but what I think this page still lacks is the information about the callable signature. The example doesn't specify parameter type but makes assumption that it's always string. Is that true?

Yeah it is always a string: https://3v4l.org/J6k7r

Good. Interesting that the last two didn't even trigger the callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants