Adds a note about hooks + constructor property promotion #4264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per a conversation with @Crell, added a note to detail behavior of hooks when the set hook allows more types than the property, and is used with constructor property promotion.
Girgias
requested changes
Dec 6, 2024
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
|
The text looks good to me, but there's some linting issues. Once those are resolved I think we can merge this. |
|
I think I've resolved the linting issues, but the build chain does not work currently (I get errors on |
|
All clear now. @Girgias do you want to clear your change request and merge? |
Girgias
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a conversation with @Crell, added a note to detail behavior of hooks
when the set hook allows more types than the property, and is used with
constructor property promotion.