remove deprecated example, add multidimensional arrays examples #4394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludrob
commented
Jan 15, 2025
sy-records
reviewed
Jan 15, 2025
Co-authored-by: Luffy <52o@qq52o.cn>
sy-records
approved these changes
Jan 15, 2025
Girgias
reviewed
Jan 27, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Minor wording nit as the manual should not use personalization (i.e. you) and refer also object properties.
Girgias
reviewed
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue: #4390
This PR addresses issues with the "empty()" documentation.
1- one of the "String Offsets" examples contains an invalid example with deprecated syntax
2- add examples for multidimensional arrays