Skip to content

Add preg_last_error_msg documentation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

nicoSWD
Copy link

@nicoSWD nicoSWD commented Feb 25, 2020

This PR adds the documentation for preg_last_error_msg, added in php-src/pull/5185

Here's a rendered version of the manual page
Screenshot

@nikic
Copy link
Member

nikic commented Feb 26, 2020

@salathe @cmb69 What's our policy on docs for functions in not yet released PHP versions?

@cmb69
Copy link
Member

cmb69 commented Feb 26, 2020

Usually, we document only after features have been released (GA).

@nicoSWD
Copy link
Author

nicoSWD commented Feb 26, 2020

@nikic @cmb69 fair enough. Should I close and re-submit this PR once it's released?

@nikic
Copy link
Member

nikic commented Feb 26, 2020

As we tend to do lag behind when it comes to updating the manual for new PHP versions, maybe it would make sense to include the documentation right away, but add a warning box along the lines of "This function is only available in pre-release versions of PHP" or so?

@cmb69
Copy link
Member

cmb69 commented Feb 26, 2020

Another option would be to keep such PRs open, but tag them with something like "PHP 8.0", so they can be merged when the migration guide is written.

@salathe
Copy link
Contributor

salathe commented Mar 7, 2020

Another option would be to keep such PRs open, but tag them with something like "PHP 8.0", so they can be merged when the migration guide is written.

For what it's worth, this is my preference.

@cmb69 cmb69 added the PHP 8.0 label Mar 7, 2020
@cmb69
Copy link
Member

cmb69 commented Mar 7, 2020

I've did that now, but actually a PHP 8.0 milestone might be more apt.

@divinity76
Copy link
Contributor

can't we just have a PHP8 branch where we put all the PHP8 stuff and merge on release?

@cmb69
Copy link
Member

cmb69 commented Oct 7, 2020

Thanks for the fine patch, @nicoSWD! I have applied it as http://svn.php.net/viewvc?view=revision&revision=350809.

@cmb69 cmb69 closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants