Add links to type tags

[haszi]

Add links to all <type>s in <methodsynopsis> and <constructorsynopsis> tags. Based on #33.

Includes the following>

• refactored parameters to keep tracking of types the same way return types did
• extracted functionality to handle simple nullable types and type <span> tags into its own method and used it for parameters too
• added all types to the type link generating method
• added link to the existing void rendering method
• added tests for <methodsynopsis> and <constructorsynopsis> parameters, and <methodsynopsis> return types
• updated an existing test that included types

[haszi]

Note: there are no tests for intersection types (neither on their own nor combined with union types) as I don't know how to write the appropriate xml and couldn't find any examples of it in the English docs.

[Girgias]

Looks good just some questions/remarks

[Girgias]

Those, plus the "double" case should warn IMHO, as those are an alternative spelling for the proper built-in types that should not exist in the documentation any more. But can be a follow-up PR.

[haszi]

I was thinking about this and other warnings. There's a whole range of formatting and logic errors we could catch in Phd from whitespace in all sorts of tags, incompatible type combinations, etc.
If this was implemented as some sort of option that Phd could be called from the command line with, this whole doc checker could be added as an additional step to the documentations' pull request workflow. Maybe?

[Girgias]

I think this makes sense, but I was certain we already had support for warnings in PhD as I had seen them 🤔

Maybe if it's a new render that runs fast and doesn't need indexing, having it run on CI would make sense. Last time it came up there were concerns about the CI taking too long, or running too frequently as a PR might be update often in quick successions

[haszi]

Oh, yeah. The error handler is right there in functions.php, a file included in everything Phd which I also never looked inside. :-)

So this format would be called with the --noindex option, it would have to override the createLink(), update() and appendData() methods at a minimum, and it's validation method(s) could return null and would raise warnings on validation errors. Sounds fairly simple, so it's probably far from it. :-)

[Girgias]

As everything with PhD :D it looks simple and it isn't :D

[Girgias]

Final late remark :)

[haszi]

I changed all type_separator properties to arrays and added a type_separator_stack property. The former holds the separator following the type with the corresponding index number in the types array, and the latter keeps track of the stack of separators during processing of tags/text and is used to fill the former.

[Girgias]

Looks good to me :)

Sorry for the delay was at PHP UK

[haszi]

Looks good to me :)

Sorry for the delay was at PHP UK

I appreciate you taking the time to review these PR at all. :-) Especially that you made it very clear that Phd is not too close to your heart, to put it mildly. :-)