Skip to content

arginfo_zpp_mismatch.phpt and friends only tests statically built extensions on CI #15392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmb69 opened this issue Aug 13, 2024 · 2 comments

Comments

@cmb69
Copy link
Member

cmb69 commented Aug 13, 2024

Description

There are a couple of tests (see below) which iterate over all declared classes, and instantiate them. However, these tests don't load any shared extensions on CI, so the respective classes are not tested. I don't think this is intentional, but rather an oversight (when we switched to loading shared extensions via dl()).

Test that there is no arginfo/zpp mismatch [.\Zend\tests\arginfo_zpp_mismatch.phpt]
Test that there is no arginfo/zpp mismatch in strict mode [.\Zend\tests\arginfo_zpp_mismatch_strict.phpt]
Try to instantiate all classes without arguments [.\Zend\tests\instantiate_all_classes.phpt]
Object free handler must call zend_weakrefs_notify [.\Zend\tests\weakrefs\notify.phpt]

PHP Version

PHP 8.1

Operating System

any

@cmb69
Copy link
Member Author

cmb69 commented Aug 13, 2024

@nielsdos, this is the reason of the test issues I've mentioned in #14282 (comment) (plus PR #15378).

@cmb69
Copy link
Member Author

cmb69 commented Aug 13, 2024

Maybe we should add support for * in the --EXTENSIONS-- section (to load all available shared extensions) to run-tests.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant