Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests with opcache loaded in ZTS #8588

Closed
arnaud-lb opened this issue May 20, 2022 · 3 comments
Closed

Broken tests with opcache loaded in ZTS #8588

arnaud-lb opened this issue May 20, 2022 · 3 comments
Labels
Bug Extension: opcache Status: Verified

Comments

@arnaud-lb
Copy link
Member

arnaud-lb commented May 20, 2022 •
edited
Loading

Description

The following tests are broken in ZTS builds with JIT enabled opcache:

Bug #78376 (Incorrect preloading of constant static properties) [ext/opcache/tests/bug78376.phpt]
Bug #78175.2 (Preloading segfaults at preload time and at runtime) [ext/opcache/tests/bug78175_2.phpt]
Preloading inherited method with separated static vars [ext/opcache/tests/preload_method_static_vars.phpt]
Preload trait with static variables in method [ext/opcache/tests/preload_trait_static.phpt]

They fail when executed with -d zend_extension=opcache.so -d opcache.enable_cli=1 in non-debug ZTS builds.

See #8569 (comment)

I'm going to mark these tests as XFAIL so that #8569 can be merged. I'm opening this issue to keep track of this.

PHP Version

PHP 8.0 8735ae9

Operating System

No response
arnaud-lb added a commit to arnaud-lb/php-src that referenced this issue May 20, 2022
@arnaud-lb
XFAIL tests (phpGH-8588)
f2ac4f2
arnaud-lb added a commit to arnaud-lb/php-src that referenced this issue May 20, 2022
@arnaud-lb
Merge branch 'PHP-8.0' into PHP-8.1
6465f3e 
* PHP-8.0:
  XFAIL tests (phpGH-8588)
  Stop closing stderr and stdout streams (php#8569)
arnaud-lb added a commit to arnaud-lb/php-src that referenced this issue May 20, 2022
@arnaud-lb
Revert "XFAIL tests (phpGH-8588)"
c88dc44 
This reverts commit f2ac4f2.
arnaud-lb added a commit to arnaud-lb/php-src that referenced this issue May 20, 2022
@arnaud-lb
Merge branch 'PHP-8.1'
980385d 
* PHP-8.1:
  Stop closing stderr and stdout streams (php#8570)
  Revert "XFAIL tests (phpGH-8588)"
  XFAIL tests (phpGH-8588)
  Stop closing stderr and stdout streams (php#8569)
@arnaud-lb arnaud-lb mentioned this issue May 20, 2022
Merged
@arnaud-lb arnaud-lb changed the title Broken tests with JIT enabled in ZTS Broken tests with opcache loaded in ZTS May 20, 2022
@nielsdos
Copy link
Member

nielsdos commented Mar 2, 2023

I tried reproducing this but I can't, the tests pass: it's in the warn summary "XFAIL section but test passes".
Looking at recent CI runs of ZTS builds, it seems to pass as well.
Maybe whatever was the issue back then was fixed in the meantime?

@arnaud-lb
Copy link
Member Author

Indeed. These tests do not appear to fail in PHP-8.1. According to bisect, this was fixed in 36d2dd0.

I will remove the xfails and close this bug.

@arnaud-lb arnaud-lb mentioned this issue Mar 17, 2023
Merged
@arnaud-lb
Copy link
Member Author

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Extension: opcache Status: Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arnaud-lb @nielsdos