Fix GH-11603: Set LDFLAGS #11605
Merged
Fix GH-11603: Set LDFLAGS #11605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two unsets before the last `unset LIBS LDFLAGS` are not necessary so LDFLAGS can be adjusted via command line: LDFLAGS="..." ./configure Co-authored-by: Max Kellermann <max.kellermann@ionos.com>
Girgias
approved these changes
Jul 7, 2023
|
Maybe we should document this change in UPGRADING.internals? Just to give a hint to somebody who might be experiencing issues? |
I think so, especially because of the emails on internals. |
|
Done in c6e934b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11603
The two unsets before the last
unset LIBS LDFLAGSare not necessary so LDFLAGS can be adjusted via command line:LDFLAGS="..." ./configureMore info was discussed here #10678