Fix use-of-uninitialized-value when calling php_posix_stream_get_fd #11694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a double pointer to php_stream_cast means the caller of php_posix_stream_get_fd will never receive the actual value. Moreover, php_posix_stream_get_fd may only write the high sizeof(php_socket_t) bytes of fd, so we need to initialize the lower bytes to 0 to avoid partial use-of-uninitialized-value.
The
(void*)&fd
typo tells me that the tests aren't actually testing much. 😏