Skip to content

Improve ext/pdo_pgsql tests cleanup #11855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Contributor

Following 66b359e, adding a few queries to clean-up database after executing tests of ext/pdo_pgsql.

@kamil-tekiela
Copy link
Member

I agree this should go into --CLEAN-- and I made a mistake in my commit. I also think this PR should go only on master. This is not a bug fix so it should not be based on PHP 8.1 branch.

@alexandre-daubois
Copy link
Contributor Author

Alright, I'll rebase on master

@alexandre-daubois alexandre-daubois force-pushed the improve-pdo_pgsql-tests-cleanup branch from 767f0cc to c00339c Compare August 4, 2023 16:44
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

@Girgias Girgias merged commit 4f84b15 into php:master Aug 5, 2023
@alexandre-daubois alexandre-daubois deleted the improve-pdo_pgsql-tests-cleanup branch August 5, 2023 10:32
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants