Skip to content

Repeat dynamic property check after __isset for ?? #12698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Repeat dynamic property check after __isset for ?? #12698

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

Fixes GH-12695

bwoebi
bwoebi reviewed Nov 17, 2023
View reviewed changes
@iluuu1994 iluuu1994 force-pushed the repeat-dynamic-property-check-after-isset branch from 4df25e1 to fb167e3 Compare November 17, 2023 15:23
@iluuu1994 iluuu1994 marked this pull request as ready for review November 17, 2023 15:37
@iluuu1994 iluuu1994 requested a review from dstogov as a code owner November 17, 2023 15:37
@iluuu1994
Copy link
Member Author

Looks like this might cause a small slowdown (https://github.com/php/php-src/actions/runs/6905872077?pr=12698) but the benchmark is not quite stable enough to be sure (non-JIT is generally more reliable).

dstogov
dstogov reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, this shouldn't be changed without a big reason.

@dstogov dstogov mentioned this pull request Dec 1, 2023
Closed
@iluuu1994
Copy link
Member Author

Closed in favor of lazy objects.

@iluuu1994 iluuu1994 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov left review comments

@bwoebi bwoebi bwoebi left review comments

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong magic methods sequence with ?? operator
3 participants
@iluuu1994 @dstogov @bwoebi